Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust testcase due to differing diagnostics from JEP 445. #3042

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

rgrunber
Copy link
Contributor

@rgrunber rgrunber commented Feb 3, 2024

  • Unnamed classes (JEP 445) has changed diagnostics reported on invalid class declarations

Before JEP 445
Screenshot from 2024-02-02 20-51-20

With JEP 445
Screenshot from 2024-02-02 20-48-12

CC'in @datho7561 for awareness. We should probably run the JDT-LS tests as part of updating the incubator to avoid any surprises.

- Unnamed classes (JEP 445) has changed diagnostics reported on
  invalid class declarations

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber added the debt label Feb 3, 2024
@rgrunber rgrunber added this to the End February 2024 milestone Feb 3, 2024
@rgrunber rgrunber merged commit 92245b7 into eclipse-jdtls:master Feb 3, 2024
7 checks passed
@rgrunber rgrunber deleted the fix-testcase branch February 3, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant